Refactor and test GetDatasetDetailsPublished
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
reviewed
May 17, 2024
| if err != nil { | ||
| log.Fatal("Get dataset details failed:", err) | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
|
|
||
| _ = json.Unmarshal(body, &datasetDetails) | ||
| func makeRequest(client *http.Client, APIServer string, filter string) (*http.Response, error) { |
There was a problem hiding this comment.
it feels like this makeRequest and createFilter is in many files. If they share most of the logic, would it make sense to move them in the utils file and import accordingly?
| log.Printf("Dataset %s no infos found in catalog - will not be copied !\n", datasetId) | ||
| color.Unset() | ||
| } | ||
| func processDatasetDetails(resp *http.Response, datasetList []string) ([]Dataset, []string) { |
There was a problem hiding this comment.
isn't this block very similar to this? If so, in a later PR, we can reuse a common function
sbliven
approved these changes
May 24, 2024
|
@consolethinks if you have any free time, could you check and fix this PR (or close it all together if not relevant to your changes)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.