Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/check metadata #99

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Refactor/check metadata #99

merged 8 commits into from
Aug 23, 2024

Conversation

consolethinks
Copy link
Collaborator

Refactors checkMetadata:

  • improvements
  • error handling instead of logging
  • render some internal functions public for better flexibility down the line

Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this additional functions, as they do non trivial stuff, are worth testing

@consolethinks
Copy link
Collaborator Author

There are no new additional functions, and they're implicitly tested by the main test case. I can write tests for them, but at that point those will be new additions.

@minottic
Copy link
Collaborator

you are right, my bad

@consolethinks consolethinks merged commit 88e07c1 into main Aug 23, 2024
3 checks passed
@consolethinks consolethinks deleted the refactor/check_metadata branch August 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants