A year worth of improvements to gfdata #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so calls ll surveys
…preferentially over end_deployment and begin_retrieval times
…that sample_date sometimes is inconsistent with other data variables, so used as last resort
…reated in some surveys
…n name) to use as starting point to track overhaul
…amatically reduces but does not eliminate duplication
…misclassified as ssid 6 rather than 7; add variables--sample date, trip id, and feg_grouping_code
…ates option; remove some unused options
…sql and make calling it default true
|
I'm just going to close this pull request for now to stop every commit from triggering an email to all watchers of the repository. We can merge this into main when ready (maybe after squashing a bunch of commits?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-deals with false 0s although leaves them in by default
-better area_swept
-add a bunch of variables to commercial samples calls
-add fishing_event_id to get_sablefish_surveys