Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate overwater area for HBLL survey grids #18

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

jdunic
Copy link
Contributor

@jdunic jdunic commented Jun 26, 2024

Include comparison to HBLL INS grid overwater areas used in synoptic report and elsewhere

Question: The resulting data file is bigger than expected ~ 2 Mb and I don't know why. This is with just an area column added. Not sure if there is a way to fix this that I am missing.

More notes:

  • I think the old overwater area HBLL INS grid was missing cells that this one contains
  • There are a few discrepancies in total overwater area, but I think the version made in this PR is correct (based off visual inspection)
  • Using plotly makes it easier to zoom into and inspect grid and coastline polygon overlap: HBLL INS example
  • The survey block object could be returned as the one cropped to the BC coastline but the added polygon complexity makes the object quite large (though it can be simplified using st_simplify(), but it is probably best that users just see the source file for this dataset and crop as they need.

Jillian Dunic added 4 commits June 24, 2024 13:34
- include comparison to HBLL INS grid overwater areas used in synoptic report and elsewhere
- include comparison to HBLL INS grid overwater areas used in synoptic report and elsewhere
@seananderson
Copy link
Member

Thanks, can you add ggplot2 to 'Suggests' in the DESCRIPTION file and then check for ggplot2 in the example section, similarly to how sf is done? https://github.com/pbs-assess/gfdata/actions/runs/9686712894/job/26729747347?pr=18#step:9:220

@jdunic jdunic marked this pull request as ready for review June 26, 2024 21:32
@seananderson seananderson merged commit 240c05c into master Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants