Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: hugo >0.137.0: offer possibility to use 'withdeploy' release #658

Open
3 tasks done
deining opened this issue Nov 4, 2024 · 3 comments · May be fixed by #659
Open
3 tasks done

proposal: hugo >0.137.0: offer possibility to use 'withdeploy' release #658

deining opened this issue Nov 4, 2024 · 3 comments · May be fixed by #659
Assignees
Labels
proposal Feature request

Comments

@deining
Copy link
Contributor

deining commented Nov 4, 2024

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

As of hugo version 0.137.0, the deploy subcommand is not part of hugo's extended version any more.
If you still want to make use of hugo deploy feature, you have to download and install a release with withdeploy in the archive filename. See gohugoio/hugo#12995 for further details.

Describe the solution you'd like

As far as I can see, currently it is not possible to make use of the withdeploy version inside of a workflow definition.
Therefore I would like to propose to introduce a new boolean option withdeploy that allows to make use of the hugo version that includes the deploy feature:

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v3
        with:
          hugo-version: '0.119.0'
          extended: true
          withdeploy: true  # <-- request to add this new option

Describe alternatives you've considered

None

Additional context

None

@deining deining added the proposal Feature request label Nov 4, 2024
@arnaudlevy arnaudlevy linked a pull request Nov 5, 2024 that will close this issue
@andrlik
Copy link

andrlik commented Nov 5, 2024

Yeah, not having this option breaks any GA based deployment workflows.

@peaceiris
Copy link
Owner

Nice catch! ʕ◔ϖ◔ʔ

babar-raza added a commit to Aspose/aspose.org-workflows that referenced this issue Nov 7, 2024
kaihendry added a commit to kaihendry/dabase.com that referenced this issue Nov 9, 2024
@jbouse
Copy link

jbouse commented Dec 6, 2024

On consideration that the existing #659 doesn't check or enforce is that withdeploy is implicitly extended as it is extended_withdeploy not just withdeploy.

I didn't see anything that would catch the following invalid config:

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v3
        with:
          hugo-version: '0.137.0'
          # extended: false # Default is actually false
          withdeploy: true  # <-- request to add this new option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants