Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough add withdeploy #659

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rough add withdeploy #659

wants to merge 3 commits into from

Conversation

arnaudlevy
Copy link

Fix #658

Missing tests, not even tried as I don't have all the setup.
Hope the PR is not too bad.

@arnaudlevy arnaudlevy requested a review from peaceiris as a code owner November 5, 2024 07:22
src/get-url.ts Outdated Show resolved Hide resolved
@deining
Copy link
Contributor

deining commented Nov 10, 2024

Thanks for this PR!
I took it over to my fork of this repo, made a release there and tested this release with one of my projects. Everything worked like a charm, great job!
Looking forward seeing this PR merged soon.

Copy link

@PScoriae PScoriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Fale
Copy link

Fale commented Dec 4, 2024

what's missing for this to get merged?

@SebouChu
Copy link

SebouChu commented Dec 16, 2024

Hello @PScoriae! Any update or schedule about this being merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: hugo >0.137.0: offer possibility to use 'withdeploy' release
5 participants