Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKLOG-39812] PIR report doesnt render in New Window or Via Deeplink #5517

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[BACKLOG-39812] PIR report doesnt render in New Window or Via Deeplink #5517

merged 1 commit into from
Feb 5, 2024

Conversation

singletonc
Copy link
Contributor

  • provide temporary workaround so that opened, deep-linked reports will render in new tabs
  • this breaks burger tabs menu in that this first tab will not be accessible in burger mode

@singletonc
[BACKLOG-39812] PIR report doesnt render in New Window or Via Deeplink
4785af5 
- provide temporary workaround so that opened, deep-linked reports will render in new tabs
- this breaks burger tabs menu in that this first tab will not be accessible in burger mode
@singletonc singletonc requested a review from a team as a code owner February 2, 2024 23:55
@singletonc singletonc marked this pull request as draft February 2, 2024 23:56
@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@buildguy
Copy link
Collaborator

buildguy commented Feb 3, 2024

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@buildguy
Copy link
Collaborator

buildguy commented Feb 3, 2024

✅ Build finished in 27m 26s

Build command:

mvn clean verify -B -e -Daudit -amd -pl user-console

👌 All tests passed!

Tests run: 12, Failures: 0, Skipped: 0    Test Results

ℹ️ This is an automatic message

@singletonc singletonc marked this pull request as ready for review February 5, 2024 21:21
NJtwentyone
NJtwentyone approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@NJtwentyone NJtwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, make sure to create the follow up work jira issue.

@NJtwentyone NJtwentyone merged commit 1e18926 into pentaho:master Feb 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NJtwentyone NJtwentyone NJtwentyone approved these changes

@dcleao dcleao dcleao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singletonc @buildguy @dcleao @NJtwentyone