Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPP-5021] Use a secure SAX parser which forbids external entities and #5541

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

peterrinehart
Copy link
Contributor

DTDs to prevent XXE attacks oon FileResource endpoint. The better solution would involve configuring secure XML parsing across the entire application, but our framework does not allow that easily and it would require more rework and testing than currently feasible.

DTDs to prevent XXE attacks oon FileResource endpoint. The better
solution would involve configuring secure XML parsing across the entire
application, but our framework does not allow that easily and it would
require more rework and testing than currently feasible.
@peterrinehart peterrinehart requested a review from a team as a code owner February 17, 2024 19:53
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 75.6% 75.6% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 53m 54s

Build command:

mvn clean verify -B -e -Daudit -amd -pl extensions

👌 All tests passed!

Tests run: 1547, Failures: 0, Skipped: 5    Test Results


ℹ️ This is an automatic message

@lucboudreau lucboudreau merged commit 91175bb into pentaho:master Feb 17, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants