Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BISERVER-15031] - Limit the PIR Export via REST API to the allowed types - null protection missing #5549

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

andreramos89
Copy link
Contributor

Null protection was missing from the validation

@smmribeiro
@renato-s

@andreramos89 andreramos89 requested a review from a team as a code owner February 27, 2024 16:25
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 51m 1s

Build command:

mvn clean verify -B -e -Daudit -amd -pl extensions

👌 All tests passed!

Tests run: 1547, Failures: 0, Skipped: 5    Test Results


ℹ️ This is an automatic message

Copy link
Contributor

@smmribeiro smmribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smmribeiro smmribeiro merged commit d66163c into pentaho:master Feb 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants