Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relative filename #360

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Nov 24, 2023

Fix incorrect filename due to the XML encoded href property being compared to a possibly non-encoded base url

Before

"filename": "/../aA0 _.@-'"

After

"filename": "/"

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@perry-mitchell perry-mitchell merged commit 53d73e4 into perry-mitchell:master Nov 27, 2023
6 checks passed
@Pytal Pytal deleted the fix/filename branch November 27, 2023 18:47
@perry-mitchell
Copy link
Owner

Released in 5.3.1 - Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants