Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat test not registering failures #389

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 4, 2024

No description provided.

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Dec 4, 2024

Hey @perry-mitchell, something seems wrong ⚠️
I tested some stuff locally, and couldn't get my tests to fail (I know, for this one time I was actually trying to make them fail)...

I think something is broken on this repo, you can see my edit, it should definitely be failing.
Yet, everything is green here
image

@skjnldsv skjnldsv changed the title chore: test chai failure - do not merge tests are broken, please have a look Dec 4, 2024
@perry-mitchell
Copy link
Owner

@skjnldsv Interesting! That indeed should be failing. Let me check this in the evening and I'll get back to you.

Thanks for letting me know!

@perry-mitchell
Copy link
Owner

Found the issue, and was able to get the test working:

image

I've since reverted your change.

@perry-mitchell perry-mitchell changed the title tests are broken, please have a look stat test not registering failures Dec 6, 2024
@perry-mitchell perry-mitchell merged commit 817d85e into perry-mitchell:master Dec 7, 2024
6 checks passed
@skjnldsv skjnldsv deleted the chore/test-ci branch December 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants