Skip to content

Commit

Permalink
Remove the dart:developer library from .platform files.
Browse files Browse the repository at this point in the history
We do not currently support this library.
I think we should add some minimal support in the future and created
issue dart-archive#563.

This closes issue: dart-archive#553

R=karlklose@google.com

Review URL: https://codereview.chromium.org/2113273002 .
  • Loading branch information
sigurdm committed Jul 1, 2016
1 parent 818dc7e commit ae63c06
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
1 change: 0 additions & 1 deletion lib/dartino_embedded.platform
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ core: core/embedded_core.dart

math: ../third_party/dart/sdk/lib/math/math.dart
typed_data: ../third_party/dart/sdk/lib/typed_data/typed_data.dart
developer: ../third_party/dart/sdk/lib/developer/developer.dart
collection: ../third_party/dart/sdk/lib/collection/collection.dart

_internal: ../third_party/dart/sdk/lib/internal/internal.dart
Expand Down
1 change: 0 additions & 1 deletion lib/dartino_mobile.platform
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ async: ../third_party/dart/sdk/lib/async/async.dart
collection: ../third_party/dart/sdk/lib/collection/collection.dart
convert: ../third_party/dart/sdk/lib/convert/convert.dart
core: ../third_party/dart/sdk/lib/core/core.dart
developer: ../third_party/dart/sdk/lib/developer/developer.dart
math: ../third_party/dart/sdk/lib/math/math.dart
typed_data: ../third_party/dart/sdk/lib/typed_data/typed_data.dart

Expand Down
1 change: 0 additions & 1 deletion pkg/dartino/lib/_embedder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@ embedded_libs:
'dart:dartino._ffi': '../../../internal/dartino_lib/ffi/ffi_private.dart'
'dart:dartino.os': '../../../lib/os/os.dart'
'dart:dartino.service': '../../../lib/service/service.dart'
'dart:developer': '../../../third_party/dart/sdk/lib/developer/developer.dart'
'dart:math': '../../../third_party/dart/sdk/lib/math/math.dart'
'dart:typed_data': '../../../third_party/dart/sdk/lib/typed_data/typed_data.dart'
8 changes: 8 additions & 0 deletions tests/language.status
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,14 @@ not_enough_positional_arguments_test/01: CompileTimeError
not_enough_positional_arguments_test/05: CompileTimeError
not_enough_positional_arguments_test/02: CompileTimeError

# These tests are written expecting dart:developer to always be present.
# We want to support at least parts of dart:developer - issue #562.
library_env_test/none: RuntimeError
library_env_test/has_io_support: RuntimeError
library_env_test/has_no_mirror_support: RuntimeError
library_env_test/has_no_html_support: RuntimeError
library_env_test/has_html_support: RuntimeError

[ $system == lk ]
await_for_test: Crash
bit_operations_test/01: Crash
Expand Down

0 comments on commit ae63c06

Please sign in to comment.