Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand word separators list for alt-{f, b, d}, ctrl-w combinations #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reinerRubin
Copy link

@reinerRubin reinerRubin commented Sep 10, 2018

Hello,
I love console things and enjoy "geth console" (go-ethereum) for dev-purposes. It uses the liner project.

eth.getTransactionReceipt('0xe7e83a25593e7f068a65994b2fd4226bf9fd16b6ce4abb4796c382e32eeedd57')

Strings like this are very common. And it would be very convinient if you could jump to " ( ", " ' " symbols or delete hash up to " ' ". Plus it's a bash default behavior. So I've made this pr.

I can add configurations and make this mode optional if you want. But in my opinion it's not needed.

Thanks.

@frou
Copy link
Contributor

frou commented Sep 23, 2018

FYI this topic was discussed a bit in an old unmerged PR #49

@reinerRubin
Copy link
Author

reinerRubin commented Sep 23, 2018

Thanks!

I tried to find something about custom separators but failed. If @peterh's suggestion about "SetWhitespaceFunc" is still alive, I can do it.

@peterh
Copy link
Owner

peterh commented Oct 1, 2018

Sorry for the late reply.

The general guideline (aside from single line mode) for defaults is "what does bash do?"

I just tested, and bash treats punctuation and whitespace the same for Ctrl-← and Ctrl-→ (and Alt-F and Alt-B), but only looks at whitespace for Ctrl-W.

Argh. I hate that bash is inconsistent here, so I can probably be persuaded that this change is correct, but I'd like to see more discussion of the pros and cons of this behaviour compared to adopting the bash behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants