Fix image pull secret name #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent the issue in the following scenario: 1. An image pull secret is provisioned, and a Pod successfully pulls image and starts 2. ServiceAccount's annotation is changed, resulting in a change of the image pull secret name 3. The Pod attempts to pull the image again for some reason 4. The old image pull secret has been deleted, causing the Pod to fail in pulling the image 5. Since the Pod initially started successfully in step 1, the evictor does not recover the Pod
superbrothers
approved these changes
Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent the issue in the following scenario: