Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition to determine if pod can fail to pull image later #57

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix condition to determine if pod can fail to pull image later #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/controller/evictor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,10 +299,13 @@ func (e *evictor) canFailImagePullLater(pod *corev1.Pod) bool {
return true
}

// A container's status is ContainerCreating => the container creation (including image pull) is in progress.
// A container's status is PodInitializing or ContainerCreating
// => the container creation (including image pull) is in progress.
for _, status := range append(pod.Status.InitContainerStatuses, pod.Status.ContainerStatuses...) {
if w := status.State.Waiting; w != nil && w.Reason == "ContainerCreating" {
return true
if w := status.State.Waiting; w != nil {
if w.Reason == "PodInitializing" || w.Reason == "ContainerCreating" {
return true
}
}
}

Expand Down