-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and delete only mode #14
Conversation
@@ -407,7 +407,7 @@ public MultiDeleteResponse multiDelete(@PathParam("bucket") String bucketName, | |||
MultiDeleteResponse result = new MultiDeleteResponse(); | |||
|
|||
// Check if the S3Gateway status is readonly | |||
Optional<Response> checkResult = checkIfReadonly(); | |||
Optional<Response> checkResult = checkIfReadonly(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a delete function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tasikani
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have a question.
4994053
to
062fd42
Compare
Add "deletion" exception into readonly mode (c.f. #9) . #13 needs to be merged beforehand.