Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore partitions in schema diff #8239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexander-smyslov
Copy link

Often there is a situation when the only difference in the schemes is the number of partitions. It would be convenient to have an option to ignore this

@pravesh-sharma
Copy link
Contributor

@alexander-smyslov, Just to clarify, you are trying to add an option so that if the user selects it, the schema diff will not compare the partitions of the table and will not generate any diff SQL. If this is what you're trying to achieve, then the code in the PR is not having the desired effect, it is still showing the difference.

@alexander-smyslov
Copy link
Author

@alexander-smyslov, Just to clarify, you are trying to add an option so that if the user selects it, the schema diff will not compare the partitions of the table and will not generate any diff SQL. If this is what you're trying to achieve, then the code in the PR is not having the desired effect, it is still showing the difference.

thanks for review. merge was incomplete. fixed.

@pravesh-sharma
Copy link
Contributor

pravesh-sharma commented Dec 12, 2024

@alexander-smyslov, Just to clarify, you are trying to add an option so that if the user selects it, the schema diff will not compare the partitions of the table and will not generate any diff SQL. If this is what you're trying to achieve, then the code in the PR is not having the desired effect, it is still showing the difference.

thanks for review. merge was incomplete. fixed.

The code still does not have any effect it still shows the difference between the table.

@alexander-smyslov
Copy link
Author

image

@pravesh-sharma
Copy link
Contributor

image

If we ignore the partition, it should not be shown as different; it should be shown as identical. Also, I have another test case where the source DB has a table with 3 partitions and the target DB has the same table with 2 partitions. In this case, it should also be ignored, but this is not being handled correctly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants