Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display samples for workflow execution (ENHC0010030) #631

Merged
merged 23 commits into from
Jun 25, 2024
Merged

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Jun 5, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a new project
  2. Add a sample to the project and upload sequence files to the sample.
  3. Go back to your new project samples page and select the new sample and launch a pipeline for it.
  4. Go to workflow executions and select the new one.
  5. Select the tab for Samplesheet
  6. Files should be displayed as above.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@joshsadam joshsadam added the enhancement New feature or request label Jun 5, 2024
@joshsadam joshsadam self-assigned this Jun 5, 2024
@joshsadam joshsadam marked this pull request as ready for review June 7, 2024 19:12
@joshsadam joshsadam changed the title Display samples for workflow execution (ENHC0010030) [ENHC0010030] Display samples for workflow execution Jun 10, 2024
@joshsadam joshsadam changed the title [ENHC0010030] Display samples for workflow execution Display samples for workflow execution (ENHC0010030) Jun 11, 2024
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Other than the update required to _samplesheet.html.erb to only output the puid and name of the attachment if it was provided in the samplesheet when the pipeline was ran, just one comment below

test/system/workflow_executions_test.rb Show resolved Hide resolved
Copy link
Member

@JeffreyThiessen JeffreyThiessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Just one edge case issue.

After launching a workflow execution with 0 samples (not sure if this is intended in the first place), when clicking on the samplesheet tab, the application throws a error to the user because of an undefined method.

image

test/system/workflow_executions_test.rb Show resolved Hide resolved
app/controllers/concerns/workflow_execution_actions.rb Outdated Show resolved Hide resolved
Copy link

Simplecov Report

Covered Threshold
92.4% 90%

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deepsidhu85 deepsidhu85 removed the request for review from ericenns June 25, 2024 16:48
Copy link
Member

@JeffreyThiessen JeffreyThiessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepsidhu85 deepsidhu85 merged commit fdbb4d1 into main Jun 25, 2024
3 checks passed
@deepsidhu85 deepsidhu85 deleted the we/samples branch June 25, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants