Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cancel button to filter by name or puid #802

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Oct 2, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds a new button to the footer of the filter by sample names or id dialog (Cancel)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@joshsadam joshsadam self-assigned this Oct 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@joshsadam joshsadam marked this pull request as ready for review October 2, 2024 17:38
@joshsadam joshsadam added the enhancement New feature or request label Oct 2, 2024
Copy link

github-actions bot commented Oct 4, 2024

Code Metrics Report

Coverage Test Execution Time
93.2% 7m43s

Code coverage of files in pull request scope (100.0%)

Files Coverage
app/components/list_filter_component.html.erb 100.0%
app/components/viral/dialog_component.html.erb 100.0%

Reported by octocov

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@ericenns ericenns merged commit 1b68011 into main Oct 4, 2024
3 checks passed
@ericenns ericenns deleted the filter-samples-update branch October 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants