-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata: Update values to strings #808
Open
ksierks
wants to merge
9
commits into
main
Choose a base branch
from
metadata-types-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ksierks
force-pushed
the
metadata-types-fix
branch
from
October 4, 2024 13:53
7805801
to
b121345
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 task
ksierks
force-pushed
the
metadata-types-fix
branch
from
October 4, 2024 19:03
b121345
to
b6c22b0
Compare
This comment has been minimized.
This comment has been minimized.
ksierks
force-pushed
the
metadata-types-fix
branch
from
October 4, 2024 20:17
336a6b4
to
c125318
Compare
ksierks
force-pushed
the
metadata-types-fix
branch
from
October 8, 2024 13:28
c125318
to
cc74942
Compare
Code Metrics Report
Code coverage of files in pull request scope (100.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Converting metadata values to strings, so we can search all metadata values. (See #807.)
Fixes #771.
Screenshots or screen recordings
How to set up and validate locally
Add metadata through the UI:
Import Metadata
button.Sample ID
Column.Import Metadata
button.Test searching metadata
instructions below.Add metadata through GraphQL:
http://localhost:3000
and login as admin.http://localhost:3000/graphiql
.Test searching metadata
instructions below.Test searching metadata
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.