Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity page fixes #811

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Activity page fixes #811

wants to merge 1 commit into from

Conversation

deepsidhu85
Copy link
Contributor

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR fixes incorrect breadcrumbs for project and group activity page, fixes a bug with the settings menu opening, and updates the project details page to show the count of members without automation bots

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

…d issue with settings menu not remaining open when an item was selected on the group activity page, updated project details page to show the number of members without automation bots
@deepsidhu85 deepsidhu85 marked this pull request as draft October 8, 2024 21:08
Copy link

github-actions bot commented Oct 8, 2024

Code Metrics Report

Coverage Test Execution Time
93.2% 8m1s

Code coverage of files in pull request scope (93.8%)

Files Coverage
app/components/project_dashboard/information_component.html.erb 100.0%
app/controllers/groups_controller.rb 89.3%
app/controllers/projects_controller.rb 91.9%
app/models/member.rb 96.3%
app/views/layouts/groups.html.erb 100.0%

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant