Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Post: Introducing the aNCA package for Pharmaverse! #250

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Gero1999
Copy link
Collaborator

@Gero1999 Gero1999 commented Nov 22, 2024

Closes #233

Hope everything looks good for the post!😺

To check

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the App far enough along to have a simple gif included in the post.

Just to bring some excitement!!! Lovely summary

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
@Gero1999
Copy link
Collaborator Author

p far enough along to have a simple gif included in the post.

Just to bring some excitement!!! Lovely summary

We though about it and I think is a great idea and thanks!

One quest, this is our first time publishing, is it ok if we make a future edition of the repo to include a video/gif when we have something final tailored and open a new pr?

@bms63
Copy link
Collaborator

bms63 commented Nov 22, 2024

p far enough along to have a simple gif included in the post.
Just to bring some excitement!!! Lovely summary

We though about it and I think is a great idea and thanks!

One quest, this is our first time publishing, is it ok if we make a future edition of the repo to include a video/gif when we have something final tailored and open a new pr?

Yes please keep the post updated. You can either make a new post and reference the old or just update the same post. Up to you.

We actually have it set up so if there is package code from a year ago and a new version of the package is published with breaking changes, then the post fails to build. Kind of a headache, but also means when someone comes to look at the post the code is most up to date!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Post: Introducing the aNCA package for Pharmaverse!
2 participants