Close #57: Enhance check_ct_data #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into 57_enhance_check_ct # Conflicts: # NEWS.md
tamarasenior
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Hi @anajens - the update looks great! I agree with the implementation to resolve this issue, and no issues with the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
na_acceptablenow can accept a character vector of variables in addition to NULL, TRUE, FALSEomit_vars: new argument to control if any variables should be skipped during controlled terminology checksI didn't modify the
na_acceptableargument incheck_ct_col()andget_bad_ct()as these functions are meant to check a single variable so I think the current configuration makes sense as is.