Skip to content

Commit

Permalink
Fix XMLHTTPMessageTest (Request|Response) testAddHeader and test Head…
Browse files Browse the repository at this point in the history
…erValuesAtAdd tests by not adding to the addedHeaders collection the second time

Listen to some code critics
  • Loading branch information
Sven Van Caekenberghe committed Mar 24, 2023
1 parent dd3aac2 commit eba81f2
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions src/XML-Parser-Tests/XMLHTTPMessageTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ XMLHTTPMessageTest >> assertMessage: aMessage hasHeaders: anAssociationCollectio
"use #associationsDo: to support Dictionaries and SequenceableCollections"
anAssociationCollection associationsDo: [:each |
addedHeaders add: each].
self assert: aMessage headers sorted = addedHeaders sorted.
self assert: aMessage headers sorted equals: addedHeaders sorted
]

{ #category : #accessing }
Expand Down Expand Up @@ -95,18 +95,17 @@ XMLHTTPMessageTest >> testAddHeader [
self headers do: [:each |
self deny: (message headers includes: each).

self assert: (message addHeader: each) = each.
self assert: (message addHeader: each) equals: each.
addedHeaders addLast: each.
self
assertMessage: message
hasHeaders: addedHeaders].

self headers do: [:each |
self assert: (message addHeader: each) = each.
addedHeaders addLast: each.
self assert: (message addHeader: each) equals: each.
self
assertMessage: message
hasHeaders: addedHeaders].
hasHeaders: addedHeaders]
]

{ #category : #tests }
Expand Down Expand Up @@ -500,7 +499,7 @@ XMLHTTPMessageTest >> testHeaderValuesAtAdd [
self assert:
(message
headerValuesAt: each key
add: each value) = each value.
add: each value) equals: each value.
addedHeaders addLast: each.
self
assertMessage: message
Expand All @@ -510,11 +509,10 @@ XMLHTTPMessageTest >> testHeaderValuesAtAdd [
self assert:
(message
headerValuesAt: each key
add: each value) = each value.
addedHeaders addLast: each.
add: each value) equals: each value.
self
assertMessage: message
hasHeaders: addedHeaders].
hasHeaders: addedHeaders]
]

{ #category : #tests }
Expand Down

0 comments on commit eba81f2

Please sign in to comment.