(WIP) Add :scope selector
#36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’d definitely prefer this change to happen on the esquery side, as I really don’t want the selector syntax to diverge. I think the existing branch there is in a pretty good shape, it just needs tests. TSQuery would then get the new syntax for free. Would you be keen to pick up the PR on the other repo? |
|
I will add the tests on the PR from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to help on the
:scopeselector, for now I just managed to remove esquery and add the parser which was on this pull requesthttps://github.com/estools/esquery/pull/61. But I'm not sure it's the good way to do it.I launched the tests with the new parser and all tests are green.
From this I wanted to add the
:scopeoperator but I have to admit I am a little lost...If someone can give me some guidance I'll be very happy to help adding this new feature.
While waiting for your answer, I will continue to search on my own :)