Add NATS Jetstream KV Store implementation #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vokey <code@vokeylee.com>
… methods Signed-off-by: Vokey <code@vokeylee.com>
The test uses an embedded nats server to simplify the test procedure. Signed-off-by: Vokey <code@vokeylee.com>
Signed-off-by: Vokey <code@vokeylee.com>
…tion comments Signed-off-by: Vokey <code@vokeylee.com>
Signed-off-by: Vokey <code@vokeylee.com>
vokey
commented
Nov 17, 2024
| return err | ||
| } | ||
|
|
||
| ctxWithTimeout, cancel := context.WithTimeout(context.TODO(), c.timeout) // Use TODO since context is not available yet. |
There was a problem hiding this comment.
As mentioned in the issue comment at #136 (comment), the operation timeout is configured in the Client settings currently, and you're considering changing the interface and using context to set the timeout in a future version.
Therefore, I have used context.TODO as the parent context as a placeholder.
| var ts *server.Server | ||
|
|
||
| // TestMain initializes the embedded nats server and runs the tests. | ||
| func TestMain(m *testing.M) { |
There was a problem hiding this comment.
I used an embedded sever to simplify the test procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Philipp,
the
gokvlibrary is fantastic and easy-to-use. I've contributed an implementation for the NATS Jetstream KV store. NATS is a high-performance, increasingly popular distributed messaging system, I believe this addition could be valuable. I would greatly appreciate it if you would consider merging it into the project.