Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languagetool: disable specific rules #158

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

mateusz-bloch
Copy link
Contributor

@mateusz-bloch mateusz-bloch commented Aug 9, 2023

Disabled rules:

Examples why it's needed to disabled them:

ENGLISH_WORD_REPEAT_RULE :
image

RB_RB_COMMA[3]:
image

REP_PASSIVE_VOICE[6]:
image

AI[1]:
image

ID_CASING[2]:
image

ENGLISH_WORD_REPEAT_BEGINNING_RULE:
image

EN_UNPAIRED_BRACKETS:
image

@mateusz-bloch mateusz-bloch marked this pull request as draft August 9, 2023 11:40
test.md Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
test.md Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch 2 times, most recently from 709000c to d96fdde Compare August 9, 2023 13:32
@mateusz-bloch mateusz-bloch marked this pull request as ready for review August 9, 2023 13:35
@mateusz-bloch mateusz-bloch marked this pull request as draft August 11, 2023 13:51
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from d96fdde to 9f7607c Compare August 17, 2023 12:32
corelibs/libgraph.md Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from 42c9b8f to 4486f1b Compare August 17, 2023 14:02
corelibs/libgraph.md Outdated Show resolved Hide resolved
kernel/vm/README.md Outdated Show resolved Hide resolved
corelibs/libgraph.md Outdated Show resolved Hide resolved
kernel/vm/README.md Outdated Show resolved Hide resolved
kernel/proc/sync.md Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch 3 times, most recently from 99fa0fe to e03126e Compare August 21, 2023 10:21
@mateusz-bloch mateusz-bloch marked this pull request as ready for review August 21, 2023 10:24
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed let's leave LC_AFTER_PERIOD and DATE_WEEKDAY_WITHOUT_YEAR

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from e03126e to 18822f9 Compare August 22, 2023 13:57
@nalajcie
Copy link
Member

small note: please use imperative mood in commit messages (disable instead od disabled).

Worth considering: most of the issues stem from markdown code blocks being checked as native text - the ideal solution would be to make languagetool NOT check the code blocks at all (that way we could keep the rules enabled for native text). From quick research - I haven't found out-of-the box solution for it, but it probably could be done by LanguageTool API (so, writing our custom languagetool-based checker) and using it in CI.

@mateusz-bloch mateusz-bloch marked this pull request as draft August 29, 2023 11:38
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct commit messages and leave the mentioned comment (or sth similar) - IMHO we can merge it for now.

.github/workflows/lint.yml Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from 18822f9 to e10363a Compare September 29, 2023 11:59
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch 2 times, most recently from 4ab49d6 to c375bc6 Compare September 29, 2023 13:07
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from c375bc6 to 87e2230 Compare September 29, 2023 13:11
@mateusz-bloch mateusz-bloch marked this pull request as ready for review September 29, 2023 13:13
@mateusz-bloch mateusz-bloch changed the title languagetool: disabled specific rules languagetool: disable specific rules Oct 2, 2023
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/language_tool_rules_disabled branch from 87e2230 to 1f9df7e Compare October 2, 2023 09:56
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianloew damianloew merged commit 1a3c7f8 into master Oct 2, 2023
3 checks passed
@damianloew damianloew deleted the mateusz-bloch/language_tool_rules_disabled branch October 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants