Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc_join: fix race condition #426

Merged
merged 1 commit into from
Aug 3, 2023
Merged

proc_join: fix race condition #426

merged 1 commit into from
Aug 3, 2023

Conversation

lukileczo
Copy link
Member

Description

Fix race condition while waiting for threads to end - lastChecked thread might've been joined by a different thread and no longer belong to ghosts list - therefore causing NULL dereference.

Motivation and Context

JIRA: RTOS-542

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-dataro

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit 09c583a into master Aug 3, 2023
25 checks passed
@lukileczo lukileczo deleted the lukileczo/rtos-542 branch August 3, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants