Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix: fix socket flags #579

Merged
merged 1 commit into from
Aug 28, 2024
Merged

unix: fix socket flags #579

merged 1 commit into from
Aug 28, 2024

Conversation

ziemleszcz
Copy link
Contributor

@ziemleszcz ziemleszcz commented Aug 21, 2024 •
edited
Loading

Sockets can read and write by default. Required for fdopen() to work on unix sockets.

JIRA: RTOS-892

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@ziemleszcz ziemleszcz self-assigned this Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 3s ⏱️ - 2m 2s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 23b18b3. ± Comparison against base commit fa2cb46.

♻️ This comment has been updated with latest results.

@ziemleszcz
unix: fix socket flags
23b18b3 
Sockets can read and write by default. Required for fdopen() to work on unix sockets.
F_SETFL returns 0 on success.

JIRA: RTOS-892
@ziemleszcz ziemleszcz mentioned this pull request Aug 22, 2024
Open
14 tasks
@ziemleszcz ziemleszcz marked this pull request as ready for review August 22, 2024 11:55
@Darchiv Darchiv merged commit 2a3f1d1 into master Aug 28, 2024
30 checks passed
@Darchiv Darchiv deleted the ziemleszcz/RTOS-892 branch August 28, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darchiv Darchiv Darchiv approved these changes

Assignees

@ziemleszcz ziemleszcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziemleszcz @Darchiv