Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busybox: enable testcase logging #69

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mateusz-bloch
Copy link
Member

@mateusz-bloch mateusz-bloch commented Nov 7, 2023

JIRA: CI-384

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/busybox_testcase_logging branch from 16b34ed to 7b4a54a Compare November 7, 2023 19:04
Copy link

github-actions bot commented Nov 7, 2023

Unit Test Results

5 957 tests  +334   5 316 ✔️ +316   30m 42s ⏱️ + 3m 24s
   333 suites +  35      641 💤 +  19 
       1 files   ±    0          0  -     1 

Results for commit 3ba316c. ± Comparison against base commit 9feddd4.

This pull request removes 1 and adds 335 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/misc ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/misc
flash ‑ riscv64-generic-qemu:flash
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_few_calls
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_register_inside
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_two_nodes
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.stdlib_exit.stream_flush
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.unistd_Exit.SIGCHLD_sent
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.unistd_Exit.chk_if_exits
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.unistd_Exit.close_streams
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.unistd_Exit.exit_status_waitpid
phoenix-rtos-tests/libc/exit ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/exit.unistd_Exit.new_parent_id
…

♻️ This comment has been updated with latest results.

busybox/19-enable-testcase-logging.patch Outdated Show resolved Hide resolved
busybox/19-enable-testcase-logging.patch Outdated Show resolved Hide resolved
busybox/19-enable-testcase-logging.patch Outdated Show resolved Hide resolved
+ echo "Running testcase $NAME"
[ -z "$VERBOSE" ] || echo "echo -ne '$4' >input"
[ -z "$VERBOSE" ] || echo "echo -ne '$5' | $2"
$ECHO -ne "$5" | eval "$2" > actual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are also other places where test cases start:
Screenshot from 2023-11-08 12-35-25

There you also don't know when you should start parsing output.

Please correct it, run all the tests and make sure that all the output is formatted correctly.

Copy link
Member Author

@mateusz-bloch mateusz-bloch Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it turns out that in the new style of BusyBox tests, some may include checks within the test itself. Currently, this is only the case for bunzip2.tests and bzcat.tests.

After the recent changes:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one more nitpick: maybe it would be good to do ---Testcase 'testcase name' starting---

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean that?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that what it was about?:
image

I didn't understand, previously I changed only that the testcase was printed and not the entire path in one case of printning logs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/busybox_testcase_logging branch from 7b4a54a to 5c484af Compare November 8, 2023 12:34
@mateusz-bloch mateusz-bloch marked this pull request as ready for review November 8, 2023 12:58
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/busybox_testcase_logging branch 4 times, most recently from 3cf8e34 to 95ae0a4 Compare November 8, 2023 14:29
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/busybox_testcase_logging branch from 95ae0a4 to 3ba316c Compare November 8, 2023 15:24
@damianloew damianloew merged commit 09dea94 into master Nov 16, 2023
30 checks passed
@damianloew damianloew deleted the mateusz-bloch/busybox_testcase_logging branch November 16, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants