lwip-tests: create port enabling run of lwip tests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adamdebek
force-pushed
the
adamdebek/lwip-tests
branch
from
76cff89
to
ebecbb7
Compare
nalajcie
reviewed
Jan 12, 2024
lwip-tests/build.sh
Outdated
| mkdir -p "${PREFIX_CHECK_BUILD}/include" | ||
| if [ ! -f "{$PREFIX_CHECK_BUILD}/config.h" ]; then | ||
| CHECK_CFLAGS="-std=gnu99 -I${PREFIX_CHECK_BUILD}/include" | ||
| (cd "$PREFIX_CHECK_SRC" && autoreconf -i -v -f && \ |
There was a problem hiding this comment.
is autoreconf really necessary? (shouldn't be)
There was a problem hiding this comment.
There is no default configure script so I need to generate it using autoreconf
lwip-tests/build.sh
Outdated
| b_log "Building lwip-test" | ||
|
|
||
| LWIP_CONTRIB_COMMIT="35b011d4cf4c4b480f8859c456587a884ec9d287" | ||
| LWIP_CONTRIB_PKG_URL="https://github.com/particle-iot/lwip-contrib/archive/${LWIP_CONTRIB_COMMIT}.tar.gz" |
There was a problem hiding this comment.
use release tag, maybe use official git repo (eg. https://git.savannah.nongnu.org/cgit/lwip/lwip-contrib.git/snapshot/lwip-contrib-STABLE-2_1_0_RELEASE.tar.gz)?
is contrib only needed for unix port? (host testing?)
adamdebek
force-pushed
the
adamdebek/lwip-tests
branch
from
ebecbb7
to
484d8c8
Compare
adamdebek
force-pushed
the
adamdebek/lwip-tests
branch
from
484d8c8
to
8655c66
Compare
JIRA: CI-329
adamdebek
force-pushed
the
adamdebek/lwip-tests
branch
from
8655c66
to
d721a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CI-329
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment