Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exported STRIP to strip binaries #77

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented May 28, 2024

Description

  • Use exported STRIP to strip binaries
  • Fix flag passing in coremark port

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

coremark/build.sh Show resolved Hide resolved
picocom/build.sh Show resolved Hide resolved
agkaminski
agkaminski previously approved these changes May 28, 2024
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nalajcie
nalajcie previously approved these changes May 28, 2024
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add TODO in micropython build.sh to switch to use $STRIP manually?

Other than that, LGTM (CI would fail here, if you have time, you can merge build change, update project and then re-run the CI here (ports are being built only on ports PRs/commits and in nightly campaigns))

Copy link

Unit Test Results

7 460 tests  ±0   6 745 ✅ ±0   38m 21s ⏱️ - 2m 45s
  420 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit b6df9b0. ± Comparison against base commit be677de.

@lukileczo lukileczo merged commit 44ea242 into master May 28, 2024
32 checks passed
@lukileczo lukileczo deleted the lukileczo/strip-fix branch May 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants