Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coreMQTT library #80

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add coreMQTT library #80

merged 1 commit into from
Nov 18, 2024

Conversation

mateuszkobak
Copy link
Contributor

@mateuszkobak mateuszkobak commented Jul 3, 2024 •
edited
Loading

Description

Porting a lightweight MQTT client library coreMQTT

JIRA-NIL588

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt117x.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Unit Test Results

7 949 tests  +226   7 231 ✅ +223   42m 53s ⏱️ + 4m 53s
  461 suites + 18     718 💤 +  3 
    1 files   ±  0       0 ❌ ±  0 

Results for commit a83ff96. ± Comparison against base commit 549e10b.

♻️ This comment has been updated with latest results.

nalajcie
nalajcie reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some remarks :)

coreMQTT/build.sh Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated

mkdir -p "$PREFIX_COREMQTT_BUILD" "$PREFIX_COREMQTT_INSTALL"
if [ ! -f "$PREFIX_COREMQTT/v${COREMQTT_VERSION}.tar.gz" ]; then
wget "$PKG_URL" -P "${PREFIX_COREMQTT}" --no-check-certificate;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mirror location, maybe we can wait for #78 to be merged and use utility functions from there? (@Darchiv)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using functions from #78 now, but I haven't created the mirror yet

coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated Show resolved Hide resolved
@nalajcie nalajcie requested a review from Darchiv July 5, 2024 10:03
Darchiv
Darchiv reviewed Jul 9, 2024
View reviewed changes
coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/CMakeLists.txt Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated Show resolved Hide resolved
@mateuszkobak mateuszkobak force-pushed the mateuszkobak/NIL-588 branch 2 times, most recently from bfc8d6e to 1553a5e Compare September 20, 2024 07:52
@mateuszkobak
Copy link
Contributor Author

@nalajcie @Darchiv, I revised my code according to your suggestions. Please take a look if it is better now :)

@mateuszkobak mateuszkobak marked this pull request as draft September 20, 2024 08:35
Darchiv
Darchiv reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@Darchiv Darchiv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Please rebase your changes and exclude any other non-relevant commits (e.g. build and lua changes from separate branches). We are already reviewing, so also please set this PR as ready for review.

coreMQTT/build.sh Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated Show resolved Hide resolved
coreMQTT/build.sh Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Nov 15, 2024
View reviewed changes
build.sh Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./phoenix-rtos-ports/build.subr: openBinaryFile: does not exist (No such file or directory) SC1091

phoenix-rtos-ports/build.sh

Line 78 in 113214d

source "${PREFIX_PROJECT}/phoenix-rtos-ports/build.subr"

@mateuszkobak mateuszkobak marked this pull request as ready for review November 15, 2024 14:44
Darchiv
Darchiv reviewed Nov 18, 2024
View reviewed changes
coreMQTT/build.sh Outdated Show resolved Hide resolved
Darchiv
Darchiv previously approved these changes Nov 18, 2024
View reviewed changes
Darchiv
Darchiv reviewed Nov 18, 2024
View reviewed changes
coreMQTT/build.sh Outdated Show resolved Hide resolved
@mateuszkobak
Add coreMQTT library
a83ff96 
JIRA: NIL-588
@Darchiv Darchiv merged commit aa8d22d into master Nov 18, 2024
36 checks passed
@Darchiv Darchiv deleted the mateuszkobak/NIL-588 branch November 18, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@nalajcie nalajcie nalajcie left review comments

@Darchiv Darchiv Darchiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszkobak @Darchiv @nalajcie