-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x264: add compilation script #84
Draft
niewim19
wants to merge
10
commits into
master
Choose a base branch
from
niewim19/x264
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d9ec425
x264: preliminary compilation script
niewim19 dde8200
x264: add `mmap()` arguments allignment
niewim19 01131fe
x264: switch to tarball download
niewim19 7ac82b3
xc264: adjust stack size
niewim19 18b1fc7
x264: disable malloc.h usage
niewim19 4efb0f1
x264: disable threading throug option, not patch
niewim19 dbf53c3
x264: reformat `input.patch` with `#ifdef phoenix`
niewim19 301e65c
x264: do not use `master` branch for source code
niewim19 8faa78d
x264: describe oconfiguration options
niewim19 6778959
x264: enable asm optimization for armv7a9 platform
niewim19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -e | ||
|
||
PREFIX_X264="${PREFIX_PROJECT}/phoenix-rtos-ports/x264" | ||
PREFIX_X264_BUILD="${PREFIX_BUILD}/x264" | ||
PREFIX_X264_CONFIG="${PREFIX_X264}/patches" | ||
PREFIX_X264_MARKERS="${PREFIX_X264_BUILD}/markers" | ||
|
||
PKG_COMMIT="31e19f92f00c7003fa115047ce50978bc98c3a0d" | ||
PKG_NAME="x264-${PKG_COMMIT}.tar.gz" | ||
PKG_URL="https://code.videolan.org/videolan/x264/-/archive/${PKG_COMMIT}" | ||
|
||
b_log "Building x264" | ||
|
||
# | ||
# Download archived source code | ||
# | ||
if [ ! -f "$PREFIX_X264/${PKG_NAME}" ]; then | ||
if ! wget "${PKG_URL}/${PKG_NAME}" -O "${PREFIX_X264}/${PKG_NAME}" --no-check-certificate; then | ||
echo "Mirror unavailable" | ||
exit 1 | ||
fi | ||
fi | ||
|
||
# | ||
# Unpack source code | ||
# | ||
if [ ! -d "${PREFIX_X264_BUILD}" ]; then | ||
tar -xf "${PREFIX_X264}/${PKG_NAME}" -C "${PREFIX_BUILD}" | ||
(cd "${PREFIX_BUILD}" && mv "${PKG_NAME%.tar.gz}" x264) | ||
mkdir -p "${PREFIX_X264_MARKERS}" | ||
fi | ||
|
||
# | ||
# Apply patches | ||
# | ||
for patchfile in "$PREFIX_X264_CONFIG"/*.patch; do | ||
if [ ! -f "$PREFIX_X264_MARKERS/$(basename "$patchfile").applied" ]; then | ||
echo "applying patch: $patchfile" | ||
patch -d "$PREFIX_X264_BUILD" -p1 < "$patchfile" | ||
touch "$PREFIX_X264_MARKERS/$(basename "$patchfile").applied" | ||
fi | ||
done | ||
|
||
# | ||
# Prepare CFLAGS and LDFLAGS for x264 configure & Makefile | ||
# | ||
export LDFLAGS_EXTRA="${CFLAGS} ${LDFLAGS} -Wl,-z,stack-size=65536" | ||
export CFLAGS_EXTRA="${CFLAGS}" | ||
export LDFLAGS="" | ||
export CFLAGS="" | ||
|
||
|
||
# | ||
# Prepare configuration options | ||
# | ||
if [ "${TARGET_FAMILY}" = "armv7a9" ]; then | ||
CFG_OPT=("--host=arm-linux") | ||
export AS=$CC | ||
elif [ "${TARGET_FAMILY}" = "ia32" ]; then | ||
# Assembly optimization for i386 platform is done using nasm and is not compatible with our toolchain | ||
CFG_OPT=("--host=i386-linux" "--disable-asm") | ||
else | ||
CFG_OPT=("--host=arm-linux" "--disable-asm") | ||
b_log "Warning! Phoenix-RTOS for ${TARGET_FAMILY} does not support x264 compilation (yet!)" | ||
b_log "The compilation attempt as for arm-linux will start in 5 seconds..." | ||
sleep 5 | ||
fi | ||
|
||
# mimic linux platform, enable position independent code, and generate libx264.a | ||
# avs, lavf and opencl force dynamic linking, thus they're disabled. | ||
CFG_OPT+=("--enable-pic" "--enable-static") | ||
CFG_OPT+=("--disable-avs" "--disable-lavf" "--disable-opencl") | ||
|
||
#TODO: rewrite parts of x264/common/cpu.c to support Phoenix-RTOS multithreading | ||
# x264 implementation uses GNU specific processor counting method for multithreading. | ||
# Remove this flag and see where compilation stops to start working on it. | ||
CFG_OPT+=("--disable-thread") | ||
|
||
|
||
# | ||
# Run configuration script | ||
# | ||
(cd "$PREFIX_X264_BUILD" && ./configure --extra-cflags="$CFLAGS_EXTRA" --extra-ldflags="$LDFLAGS_EXTRA" --cross-prefix="$CROSS" --sysroot="$PREFIX_BUILD/sysroot/" "${CFG_OPT[@]}") | ||
|
||
# | ||
# Build and install x264 binary | ||
# | ||
(cd "$PREFIX_X264_BUILD" && make) | ||
|
||
cp -a "${PREFIX_X264_BUILD}/x264" "$PREFIX_PROG_STRIPPED" | ||
b_install "$PREFIX_PORTS_INSTALL/x264" /bin/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- x264_org/configure 2024-09-06 10:29:54.767763739 +0200 | ||
+++ x264/configure 2024-09-06 10:35:58.053941778 +0200 | ||
@@ -680,7 +680,8 @@ | ||
;; | ||
*linux*) | ||
SYS="LINUX" | ||
- define HAVE_MALLOC_H | ||
+ # Phoenix-RTOS does not support malloc.h | ||
+ # define HAVE_MALLOC_H | ||
libm="-lm" | ||
;; | ||
gnu*) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
--- x264_org/input/input.c 2024-09-06 10:29:54.784756723 +0200 | ||
+++ x264/input/input.c 2024-09-06 11:05:56.206158357 +0200 | ||
@@ -227,7 +227,19 @@ | ||
} | ||
#else | ||
size_t padded_size = size + MMAP_PADDING; | ||
+#ifdef phoenix | ||
+ /** | ||
+ * PHOENIX-RTOS PATCH | ||
+ * | ||
+ * Phoenix implementation of mmap() fails if `size` is not aligned to page size | ||
+ * It is important to remove this patch when this issue is resolved. | ||
+ * | ||
+ * https://github.com/phoenix-rtos/phoenix-rtos-project/issues/1155 | ||
+ */ | ||
+ if( (base = mmap( NULL, ((padded_size + (SIZE_PAGE - 1)) & ~(SIZE_PAGE - 1)), PROT_READ, MAP_PRIVATE, h->fd, offset )) != MAP_FAILED ) | ||
+#else | ||
if( (base = mmap( NULL, padded_size, PROT_READ, MAP_PRIVATE, h->fd, offset )) != MAP_FAILED ) | ||
+#endif | ||
{ | ||
/* Ask the OS to readahead pages. This improves performance whereas | ||
* forcing page faults by manually accessing every page does not. | ||
@@ -242,7 +254,22 @@ | ||
* the file into a copy of the last valid page to prevent reads from invalid memory. */ | ||
size_t aligned_size = (padded_size - 1) & ~h->align_mask; | ||
if( offset + aligned_size >= h->file_size ) | ||
+#ifdef phoenix | ||
+ { | ||
+ /** | ||
+ * PHOENIX-RTOS PATCH | ||
+ * | ||
+ * Phoenix implementation of mmap() fails if `size` is not aligned to page size | ||
+ * It is important to remove this patch when this issue is resolved. | ||
+ * | ||
+ * https://github.com/phoenix-rtos/phoenix-rtos-project/issues/1155 | ||
+ */ | ||
+ size_t phoenix_paddedMinusAligned = padded_size - aligned_size; | ||
+ mmap( base + aligned_size, ((phoenix_paddedMinusAligned + (SIZE_PAGE - 1)) & ~(SIZE_PAGE - 1)), PROT_READ, MAP_PRIVATE|MAP_FIXED, h->fd, (offset + size - 1) & ~h->align_mask ); | ||
+ } | ||
+#else | ||
mmap( base + aligned_size, padded_size - aligned_size, PROT_READ, MAP_PRIVATE|MAP_FIXED, h->fd, (offset + size - 1) & ~h->align_mask ); | ||
+#endif | ||
|
||
return base + align; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to base new ports on this redesign: #78
I hope it will be merged soon @Darchiv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! I didn`t notice this PR. I will wait for that PR to be merged and then redo this script.