Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunner.tools: fix error message in wait_for_vid_pid() #365

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mateusz-bloch
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/fix_message_wait_for_vidpid branch from ceaf825 to 30e7dbb Compare August 8, 2024 11:39
Copy link

github-actions bot commented Aug 8, 2024

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 35s ⏱️ - 2m 9s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 0425fb3. ± Comparison against base commit ca66064.

♻️ This comment has been updated with latest results.

@mateusz-bloch mateusz-bloch marked this pull request as ready for review August 8, 2024 12:23
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's print info what device are we talking about, not only vid pid

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/fix_message_wait_for_vidpid branch 2 times, most recently from e14eb22 to 2233646 Compare August 12, 2024 11:05
@mateusz-bloch mateusz-bloch changed the title trunner.tools: fix error message in wait_for_vid_pid() trunner. tools: fix error message in wait_for_vid_pid() Aug 12, 2024
@mateusz-bloch mateusz-bloch changed the title trunner. tools: fix error message in wait_for_vid_pid() trunner.tools: fix error message in wait_for_vid_pid() Aug 12, 2024
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/fix_message_wait_for_vidpid branch from 2233646 to 244c2e7 Compare September 17, 2024 08:54
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/fix_message_wait_for_vidpid branch from 244c2e7 to 0425fb3 Compare September 20, 2024 07:33
@mateusz-bloch mateusz-bloch merged commit cf2f864 into master Sep 23, 2024
33 checks passed
@mateusz-bloch mateusz-bloch deleted the mateusz-bloch/fix_message_wait_for_vidpid branch September 23, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants