Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: re-enable tests for floats #367

Merged
merged 2 commits into from
Nov 13, 2024
Merged

libc: re-enable tests for floats #367

merged 2 commits into from
Nov 13, 2024

Conversation

jmaksymowicz
Copy link
Contributor

Re-enable tests related to issues #703, #704, #634, #652, #681

These issues were fixed by phoenix-rtos/libphoenix#370

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

github-actions bot commented Aug 20, 2024

Unit Test Results

7 958 tests  ±0   7 416 ✅ +160   40m 17s ⏱️ -3s
  470 suites +9     542 💤  - 160 
    1 files   ±0       0 ❌ ±  0 

Results for commit 464877c. ± Comparison against base commit 15f1438.

This pull request removes 729 and adds 729 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_e
…
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.inf_nan_e
…
This pull request removes 137 skipped tests and adds 33 skipped tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_e
…
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_s
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_squareBrackets.white_spaces
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_s
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_squareBrackets.white_spaces
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
…

♻️ This comment has been updated with latest results.

buff[i - 1] = i - 1;
}

/* Bypass \n bcause of issue: https://github.com/phoenix-rtos/phoenix-rtos-project/issues/679 */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[codespell] reported by reviewdog 🐶
bcause ==> because

Re-enable tests related to issues #703, #704, #634, #652, #681

JIRA: RTOS-868
Put tests for integer conversion specifiers into `test-libc-scanf-basic`
and the remaining tests into `test-libc-scanf_advanced`.
Split was made to make the tests fit on targets where RAM is limited
(e.g. stm32l4x6).

JIRA: RTOS-868
@Darchiv Darchiv merged commit 216255e into master Nov 13, 2024
36 checks passed
@Darchiv Darchiv deleted the jmaksymowicz/RTOS-868 branch November 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants