-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: add sparcv8leon3-generic-qemu target support #372
Conversation
regarding the commit message: this is not a name of any TaRgEt supported by phoenix-RTOS :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable this target to CI in a separate commit.
8f3e1a7
to
c141281
Compare
24427c5
to
b33c810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When building with tests option
LD test_mmap
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:28:2: error: #error "Unsupported target"
28 | #error "Unsupported target"
| ^~~~~
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:31:10: fatal error: grlib-multi.h: No such file or directory
31 | #include <grlib-multi.h>
| ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [../phoenix-rtos-build/Makefile.common:211: /src/_build/sparcv8leon3-generic-qemu/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.o] Error 1
make: *** Waiting for unfinished jobs....
b33c810
to
f515cfb
Compare
You could add this to the Makefile.sparcvleon3, or come up with better solution
|
1d3be02
to
65d206a
Compare
baa8005
to
2f114c5
Compare
1998544
to
500f476
Compare
78aa65c
to
8b01125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes about commit descriptions.
As it's described in our Golden Rules
- describe WHY You're doing the change in the commit message body
So you don't want to repeat what you have added in the commit message body (called also commit description). In your case the reason of adding a new target is rather obvious - we just want to support all of our available targets.
About the second commit sparcv8leon3: prevent from building test-grlib-multi on qemu target
- the commit title shows perfectly what is going on in this change, you probably want to add information WHY do we need to exclude it, so a good commit description would be:
This test is not intended to build on this particular target.
8b01125
to
a007e5d
Compare
a007e5d
to
c0b8b5c
Compare
This test is not intended to be built on this particular target. JIRA: CI-474
c0b8b5c
to
3ac9225
Compare
JIRA: CI-474
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
scripts: add sparcv8leon3-generic-qemu-test script phoenix-rtos-project#1168