Skip to content

Commit

Permalink
Fix gh16508.phpt test expectation
Browse files Browse the repository at this point in the history 
The error changed in master, not 8.4. My bad.
  • Loading branch information
@iluuu1994
iluuu1994 committed Oct 22, 2024
1 parent 18a925b commit dded6fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Zend/tests/gh16508.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ abstract class Test {

?>
--EXPECTF--
Fatal error: Class Test2 contains 1 abstract method and must therefore be declared abstract or implement the remaining method (Test::foo) in %s on line 5
Fatal error: Class Test2 contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Test::foo) in %s on line 5

8 comments on commit dded6fd

@iluuu1994
Copy link
Member Author

@iluuu1994 iluuu1994 commented on dded6fd Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 Sorry to ping you yet again. Do you have any clue why this segfaults on Windows? The actual change is here: 2d068c4 de7ef3f (It's unrelated to this commit, really)

@cmb69
Copy link
Member

@cmb69 cmb69 commented on dded6fd Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a segfault, but rather C00000FF (STATUS_BAD_FUNCTION_TABLE). Likely a JIT issue; test worked for the PHP 8.4.0RC3 builds (failed only due to wrong error message). I'll have a closer look soon.

@iluuu1994
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Christoph!

@cmb69
Copy link
Member

@cmb69 cmb69 commented on dded6fd Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly another instance of #15709. For now, I suggest to XFAIL (like 6d59620).

@iluuu1994
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 Thank you for your analysis! Do you want to add it or should I?

@cmb69
Copy link
Member

@cmb69 cmb69 commented on dded6fd Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it. Investigating more closely on that issue anyway.

@cmb69
Copy link
Member

@cmb69 cmb69 commented on dded6fd Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bdde797

@iluuu1994
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Christoph!

Please sign in to comment.