-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. cleanups #158
Misc. cleanups #158
Conversation
This fixes the underlying issue that required a `skipLibCheck` in the first place.
@@ -17,7 +17,7 @@ jobs: | |||
|
|||
# https://github.com/pnpm/action-setup | |||
- name: Install pnpm | |||
uses: pnpm/action-setup@v2 | |||
uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous action versions were deprecated and did not support new versions of node
.
@@ -30,6 +30,14 @@ | |||
color: #fff; | |||
} | |||
|
|||
.example { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a11y
reasons, the examples should be clickable elements. This should preserve the previous styling.
defining it as a function means we can simplify the reactivity
Sim. this was merged in with #160 |
Cleans up various deprecation and build warnings and does some minor cleanup and refactoring on touched files.
Testing Notes