Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add more generated columns into update list #58401

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Dec 19, 2024

What problem does this PR solve?

Issue Number: close #58400

Problem Summary:

There are two problems related to genearted column.

For Update:

When building UpdateLists for update statements, generated columns should be updated if their dependent columns have changed. However, we ignore the ON UPDATE NOW flag when extracting dependent columns. This could make certain generated columns not being updated correctly.

For Insert:

In SQL like INSERT INTO xxx VALUES xxx ON DUPLICATE KEY UPDATE xxx, the generated columns to be updated are solely determined by the assignments in UPDATE. For example:

CREATE TABLE tmv (
  J1 json, J2 json GENERATED ALWAYS AS (j1) VIRTUAL,
  UNIQUE KEY i1 ((cast(j1 as signed array))),
  KEY i2 ((cast(j2 as signed array)))
);

INSERT INTO tmv SET j1 = '[1]' ON DUPLICATE KEY UPDATE j1 = '[2]';

The dependencies of each column are listed below. Since j1 is updated, j2 and _V$_i1_0 are also updated. However, due to chain dependencies, _V$_i2_0 should also be updated too.

j2 <-- j1
_V$_i1_0 <-- j1
_V$_i2_0 <-- j2

What changed and how does it work?

In summary, when extracting generated columns, we have to consider both chain dependencies and on-update-now flag too.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Dec 19, 2024
Copy link

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rustin170506 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Dec 19, 2024
Copy link

tiprow bot commented Dec 19, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4179%. Comparing base (a3574aa) to head (0c25c92).
Report is 21 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58401        +/-   ##
================================================
- Coverage   73.5552%   73.4179%   -0.1374%     
================================================
  Files          1680       1681         +1     
  Lines        463684     466818      +3134     
================================================
+ Hits         341064     342728      +1664     
- Misses       101817     103240      +1423     
- Partials      20803      20850        +47     
Flag Coverage Δ
integration 43.3528% <100.0000%> (?)
unit 72.3056% <100.0000%> (-0.0017%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.5957% <ø> (-1.3854%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATE and INSERT ON DUPLICATE KEY doesn't update index containing generated column
1 participant