Runtime status #139
Open
Runtime status #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaileyJang
commented
Oct 2, 2021
| case MsgType.RUNTIME_STATUS: | ||
| decoded = protos.RuntimeStatus.decode(packet.payload); | ||
| //Not sure if we need to update runtimeStatus state bcs heartbeat keeps track of that already | ||
| RendererBridge.reduxDispatch(updateCodeStatus(decoded.mode)); |
There was a problem hiding this comment.
Runtime Status sends us the current run mode it is in. Calls the updateCodeStatus action to change the mode
HaileyJang
commented
Oct 2, 2021
| if (batteryParams[IS_UNSAFE] && batteryParams[IS_UNSAFE].bval) { | ||
| nextState.batterySafety = batteryParams[IS_UNSAFE].bval!; | ||
| } | ||
| if (batteryParams[V_BATT] && batteryParams[V_BATT].fval) { | ||
| nextState.batteryLevel = batteryParams[V_BATT].fval!; |
There was a problem hiding this comment.
Got removed because the batteryLevel is already changed from calling changeBatteryLevel in runtime.ts
HaileyJang
commented
Oct 2, 2021
| @@ -32,12 +30,10 @@ export const peripherals = (state: PeripheralState = initialPeripheralState, act | |||
| (action.peripherals ?? []).forEach((peripheral: Peripheral) => { | |||
| if (peripheral.name === consts.PeripheralTypes.BatteryBuzzer) { | |||
| const batteryParams = peripheral.params; | |||
| //since batterysafety is not included in runtimestatus, have to extract the value from params | |||
| if (batteryParams[IS_UNSAFE] && batteryParams[IS_UNSAFE].bval) { | |||
| nextState.batterySafety = batteryParams[IS_UNSAFE].bval!; | |||
There was a problem hiding this comment.
However batterysafety is not included in the runtime status thus extracted manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh might have some merge conflicts because of the protos submodule....