Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test numpy==2.0.0rc2 #3535

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

test numpy==2.0.0rc2 #3535

wants to merge 3 commits into from

Conversation

gojomo
Copy link
Collaborator

@gojomo gojomo commented Jun 4, 2024

Test what happens to our builds if numpy==2.0.0rc2 is specified, as Numpy 2.0 release is expected on June 16 and there may be breaking changes that torpedo our current numpy >= 1.18.5 dependency.

@piskvorky piskvorky added this to the Spring 2024 release milestone Jun 4, 2024
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 11, 2024

Looks like some parts of the numpy API we were using aren't around anymore:

gensim/models/word2vec_inner.c: In function ‘__pyx_f_5numpy_PyDataType_SHAPE’:
gensim/models/word2vec_inner.c:9378:39: error: ‘PyArray_Descr’ {aka ‘struct _PyArray_Descr’} has no member named ‘subarray’

I don't see "subarray" as member in the docs, either.

https://docs.rs/numpy/0.18.0/numpy/struct.PyArrayDescr.html

@mpenkov
Copy link
Collaborator

mpenkov commented Jun 11, 2024

@gojomo Please continue to look into this. I'm removing it from the upcoming milestone, just to get things out the door quicker.

@mpenkov mpenkov removed this from the Summer 2024 release milestone Jun 11, 2024
@gojomo
Copy link
Collaborator Author

gojomo commented Jun 12, 2024

@mpenkov I'll be tinkering, but it'll be a few minutes here and there, so unsure I'll even have a good sense of the magnitude of required changes anytime soon. I suspect the numpy release will cause hiccups & scrambles across the Python data/ML ecosystem.

So, my hunch remains: next Gensim fix release should just require numpy<2.0.0, to minimize immediate problems when it arrives, pending further work.

@jc-louis
Copy link

next Gensim fix release should just require numpy<2.0.0, to minimize immediate problems when it arrives

@gojomo numpy 2.0 stable was released yesterday

@gojomo
Copy link
Collaborator Author

gojomo commented Jun 17, 2024

@gojomo numpy 2.0 stable was released yesterday

Yes, as expected & mentioned above.

@mballintijn
Copy link

What is the expected timeline for numpy 2.x support?

@gojomo
Copy link
Collaborator Author

gojomo commented Sep 6, 2024

What is the expected timeline for numpy 2.x support?

So far I've not seen much discussion or estimation of the effort required, or anyone stepping up to take the lead – so AFAICT, timeline uncertain.

@mpenkov mpenkov mentioned this pull request Sep 9, 2024
@fpt-ian
Copy link

fpt-ian commented Oct 30, 2024

Bump, this is now starting to conflict with the rest of the environment where other packages have moved on

@YoungMind1
Copy link
Contributor

@mpenkov If it is fine by you guys; I will work towards numpy 2.0 / 2.1 support.

@hechth
Copy link

hechth commented Nov 6, 2024

@hechth @YoungMind1 is there some progress on this? I'd also be interested in that and would potentially be able to contribute.

@YoungMind1
Copy link
Contributor

@hechth I am getting cython / ABI related errors for now, trying to pin down the exact problem...

@severinsimmler
Copy link

@YoungMind1 Any news? :) Would also be happy to help out 🫡

@YoungMind1
Copy link
Contributor

@severinsimmler #3563.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants