component: consistently handle not found errors #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a github-release source is not found, kiln aborts early without trying additional release sources. This change ensures the github release source reports "ErrNotFound" so that subsequent release sources can be tried. Bumped go.mod -go=1.20 to pull in "errors.Join". kiln is already built with Go 1.20 so this seems reasonable.
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
This change was made by @abg. I am merging it after review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a github-release source is not found, kiln aborts early without trying additional release sources.
This change ensures the github release source reports "ErrNotFound" so that subsequent release sources can be tried.
Bumped go.mod -go=1.20 to pull in "errors.Join". kiln is already built with Go 1.20 so this seems reasonable.