Fix a bug in the GitHub release source #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All release sources now define their own logger by default, but allow tests to pass in a custom logger for cleaner output.
GetGithubReleaseWithTag will now return ErrNotFound if the repository owner from the GitHubRepository value in the Kilnfile release entry does not match the configured Org.
rizwanreza
deleted the
fix-github-release-source-GetGithubReleaseWithTag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the GitHub release source where it would return the actual error (instead of ErrNotFound) if the org in the specified GitHubRepository does not match the org that the release source was configured with. This caused the the loop in the GetMatchedRelease function in the ReleaseSourceList component to fail if the first GitHub release source failed, instead of continuing to try the remaining sources.