Percentage number values can contain fractions (#78)

* Percentages can be floats * `as const` allows for better types
pixijs · Jul 31, 2024 · 50888b7 · 50888b7
1 parent 4b3c559
commit 50888b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/utils/constants.ts b/src/utils/constants.ts
@@ -147,17 +147,17 @@ export const CSS_COLOR_NAMES = {
     whitesmoke: 0xf5f5f5,
     yellowgreen: 0x9acd32,
     black: 0x000000,
-};
+} as const;
 
-export const LOREM_TEXT = `Lorem ipsum dolor, sit amet consectetur adipisicing elit. 
+export const LOREM_TEXT = `Lorem ipsum dolor, sit amet consectetur adipisicing elit.
 
-Ab praesentium velit minima unde beatae. Illo earum, rem iure unde nemo, 
+Ab praesentium velit minima unde beatae. Illo earum, rem iure unde nemo,
 
 exercitationem nesciunt et voluptas nisi adipisci, provident cupiditate veritatis magnam?`;
 
-export const DISPLAY = ['block', 'inline-block', 'inline'];
+export const DISPLAY = ['block', 'inline-block', 'inline'] as const;
 
-export const OVERFLOW = ['visible', 'hidden'];
+export const OVERFLOW = ['visible', 'hidden'] as const;
 
 export const POSITION = [
     'center',
@@ -186,7 +186,7 @@ export const POSITION = [
     'bottomCenter',
     'leftCenter',
     'rightCenter',
-];
+] as const;
 
-export const ALIGN: TextStyleAlign[] = ['center', 'left', 'right', 'justify'];
-export const VERTICAL_ALIGN = ['middle', 'top', 'bottom'];
+export const ALIGN: TextStyleAlign[] = ['center', 'left', 'right', 'justify'] as const;
+export const VERTICAL_ALIGN = ['middle', 'top', 'bottom'] as const;
diff --git a/src/utils/helpers.ts b/src/utils/helpers.ts
@@ -134,7 +134,7 @@ export function getNumber(value: FlexNumber, maxPercentValue?: number): number
         }
         else if (value.endsWith('%'))
         {
-            const val = parseInt(value.slice(0, -1), 10);
+            const val = parseFloat(value.slice(0, -1));
 
             return Math.floor(maxPercentValue ? (maxPercentValue / 100) * val : val);
         }