Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

feat: Add a public method to determine if the error has been appended to the stack. #241

Closed
wants to merge 1 commit into from

Conversation

wbflooksky
Copy link

feat func ExistStack(err error) bool:

non-intrusive:
Add a public method to determine if the error has been appended to the stack.
Avoid adding the stack repeatedly for errors.

fix: error method

feat: test ExistStack

add ExistStack test

fix: error variable name

style: optimizing code structure

feat: add test example

style(value): delete func reachable code

style(build): edit format files

feat func ExistStack(err error) bool:

non-intrusive:
Add a public method to determine if the error has been appended to the stack.
Avoid adding the stack repeatedly for errors.

fix: error method

feat: test ExistStack

add ExistStack test

fix: error variable name

style: optimizing code structure

feat: add test example

style(value): delete func reachable code

style(build): edit format files
@wbflooksky
Copy link
Author

fix: #210

@puellanivis
Copy link

puellanivis commented May 25, 2021

The previous PR was already closed as “will not merge” #239 and this has no changes that we could not have come to through a code review process. (My code review was intended to help you write better code, not to get it to a state that would be merged. Sorry if it gave you a false impression.)

Please read the project’s README:

Because of the Go2 errors changes, this package is not accepting proposals for new functionality.

@wbflooksky
Copy link
Author

ok

@wbflooksky wbflooksky closed this May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants