Merge pull request #708 from bozana/10082

pkp/pkp-lib#10082 Fix getTotalGalleyViews()
pkp · Jun 19, 2024 · 3eaee33 · 3eaee33
2 parents d78592a + bb80701
commit 3eaee33
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/classes/submission/Submission.inc.php b/classes/submission/Submission.inc.php
@@ -252,13 +252,15 @@ function getTotalGalleyViews() {
 		$application = Application::get();
 		$publications = $this->getPublishedPublications();
 		$views = 0;
+		$fileIds = [];
 
 		foreach ($publications as $publication) {
 			foreach ((array) $publication->getData('galleys') as $galley) {
 				$file = $galley->getFile();
- 				if (!$galley->getRemoteUrl() && $file) {
+				if (!$galley->getRemoteUrl() && $file && !in_array($file->getId(), $fileIds)) {
  					$views = $views + $application->getPrimaryMetricByAssoc(ASSOC_TYPE_SUBMISSION_FILE, $file->getId());
- 				}
+					$fileIds[] = $file->getId();
+				}
 			}
 		}
 		return $views;