pkp/pkp-lib#10537 Add available editorial decisions to submission's stages data #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10537-main
branch
6 times, most recently
from
987dd87
to
999d868
Compare
taslangraham
commented
Oct 24, 2024
| $isOnlyRecommending = $permissions['isOnlyRecommending']; | ||
| $decisionTypes = []; /** @var DecisionType[] $decisionTypes */ | ||
|
|
||
| if ($isOnlyRecommending) { |
There was a problem hiding this comment.
ewhanson
requested changes
Oct 25, 2024
classes/submission/maps/Schema.php
Outdated
| $userHasAccessibleRoles = $user->hasRole([Role::ROLE_ID_SUB_EDITOR, Role::ROLE_ID_MANAGER, Role::ROLE_ID_SITE_ADMIN, Role::ROLE_ID_ASSISTANT], $request->getContext()->getId()); | ||
| $permissions = $this->checkDecisionPermissions($stageId, $submission, $user, $request->getContext()->getId()); | ||
|
|
||
| if (!$userHasAccessibleRoles || !$isActiveStage || !$permissions['canMakeDecision'] || $stageId !== WORKFLOW_STAGE_ID_PRODUCTION/** Only the production stage is supported in OPS.*/) { |
There was a problem hiding this comment.
I would maybe add the comment on the line above as having it in the middle if the if statement is a little hard to parse at first glance.
taslangraham
force-pushed
the
i10537-main
branch
from
999d868
to
6ae7432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#10537