Attempt to fix #285 #351
Closed
Attempt to fix #285 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tricky, see the comment. The core issue is that once a script is added to the page, there's not a generic way to check "is it loaded" (since the
loadevent won't get fired if you add a listener too late) - each script could have its own way to check (which is what we do withwindow.Plaidbelow), but there doesn't seem to be a browser API to determine this.Other solutions make different trade-offs (eg if it isn't loaded,
I also considered using
patch-package(or copy-pasting) on the script hook to implement more logic to detect if the script was