Merge pull request #225 from plausible/fix_event_name_htmlspecialchars

Fixed: HTML would break if taxonomy name contained apostrophies.
plausible · Sep 25, 2024 · ff82abc · ff82abc
2 parents 2102421 + 0610414
commit ff82abc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Filters.php b/src/Filters.php
@@ -112,7 +112,7 @@ public function maybe_add_custom_params( $params ) {
 			// Loop through the terms.
 			foreach ( $terms as $term ) {
 				if ( $term instanceof WP_Term ) {
-					$params .= " event-{$taxonomy}='{$term->name}'";
+					$params .= " event-{$taxonomy}=\"{$term->name}\"";
 				}
 			}
 		}

diff --git a/tests/integration/Integrations/WooCommerceTest.php b/tests/integration/Integrations/WooCommerceTest.php
@@ -5,10 +5,12 @@
 
 namespace Plausible\Analytics\Tests\Integration;
 
+use AllowDynamicProperties;
 use Plausible\Analytics\Tests\TestCase;
 use Plausible\Analytics\WP\Integrations\WooCommerce;
 use function Brain\Monkey\Functions\when;
 
+#[AllowDynamicProperties]
 class WooCommerceTest extends TestCase {
 	/**
 	 * @see WooCommerce::track_entered_checkout()
@@ -63,7 +65,7 @@ public function testTrackPurchase() {
 
 		when( 'wc_get_order' )->justReturn( $mock );
 
-		$this->expectOutputContains( '{"revenue":{"amount":"10.00","currency":"EUR"}}' );
+		$this->expectOutputContains( '{"revenue":{"amount":"10","currency":"EUR"}}' );
 
 		$class->track_purchase( 1 );
 	}